Hi Owen, I recently played around with the SCSS to create a more minimalist version of the bootstrap OPAC for LMSCloud. I used the predefined rules and I think they’re reasonable choices (Although I didn’t cross every rule for sure). Looking forward to stylint in Koha which I already use for some projects where I use stylus instead of SCSS. It’s a great tool. Kind regards Paul -- LMSCloud GmbH Paul Derscheid - Software Engineer Konrad-Zuse-Platz 8 - D-81829 München m +49 174 2436308 e paul.derscheid@lmscloud.de w www.lmscloud.de
On 18. Jul 2022, at 16:32, Owen Leonard <oleonard@myacpl.org> wrote:
Hi all,
Back when we switched from LESS to SCSS in the OPAC (Bug 20427) I added a linting configuration, .scss-lint.yml. I've always configured my editor to automatically lint SCSS using this configuration. I don't know if anyone else does this too.
In VS Code I was using scss-lint for this, but it's now deprecated. They suggest stylelint instead: https://stylelint.io. I'd like to propose replacing .scss-lint.yml with .stylelintrc.json, transferring most of the same rules.
It could be left up to the individual to install the dependencies, or I could update package.json. One nice thing about stylelint is that it has a "--fix" feature for some simple rules. This could be build into our gulp tasks.
Has anyone else been linting SCSS? If so, does anyone have opinions about how our current rule set is working?
-- Owen
-- Web Developer Athens County Public Libraries (740) 737-6006 https://www.myacpl.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/