Greetings, In various discussions on IRC, and in installation instructions, it seems apparent there is a lack of consistency and continuity in how SAX Parser settings should or should not be set or if another solutions, like requiring the latest MARC::File::XML, are the way to go and how should they be implemented. In the beginning, I read something like: http://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_tarball#Test_to_make_su... It was less clear and flushed out, but that was it. While tinkering around, I discovered something more like: sudo update-perl-sax-parsers --remove XML::LibXML::SAX::Parser sudo update-perl-sax-parsers --priority 100 --add XML::LibXML::SAX::Parser sudo update-perl-sax-parsers --update But didn't write it down, until tcohen did recently. :) Meanwhile, I noticed that all mention of it disappeared from documentation, though admittedly, I had started looking at Debian pages on the wiki and comparing them to the Ubuntu ones and cross-referencing to the INSTALL.ubuntu and INSTALL.debian files. INSTALL.debian still has references to SAX. INSTALL.ubuntu does not. Various conversations were held on IRC (MARC::File::XML, SAX Parser, libmarc-xml-perl): http://irc.koha-community.org/koha/2013-08-27#i_1372615 http://irc.koha-community.org/koha/2013-10-09#i_1400791 http://irc.koha-community.org/koha/2013-10-21#i_1407388 http://irc.koha-community.org/koha/2013-11-05#i_1416936 Ancient, but perhaps interesting reference material: http://irc.koha-community.org/koha/2010-03-31#i_417908 In these conversations, some have suggested CPAN'ing the MARC::File::XML. Though, the ancient link does suggest a useful apt-get way to grab from a different distribution (which is better than the wget, dpkg -I methodology I have used). So, there are few questions: 1) Is this still an issue? 2) If so, how do we solve it best? 3) If not, why is it no longer an issue? Hopefully, I am not discussing a dead horse, and have just not gotten the full update. GPML, Mark Tompsett
On Tue, Nov 5, 2013 at 2:46 PM, Mark Tompsett <mtompset@hotmail.com> wrote:
In the beginning, I read something like: http://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_ tarball#Test_to_make_sure_the_SAX_Parser_is_setup_correctly It was less clear and flushed out, but that was it.
This all became a subject for discussion when I run sax_parser_test.pl on our packages-driven production server. I was impressed that it would saying PurePerl was the current SAX parser. I remembered this being the cause of several nightmares discussed on IRC and the official lists (even koha-es). So I became aware of this and changed the wiki so we ask people to do for packages the exact thing we do for tarball installs. i.e. I proposed running this three lines sudo update-perl-sax-parsers --remove XML::LibXML::SAX::Parser
sudo update-perl-sax-parsers --priority 100 --add XML::LibXML::SAX::Parser sudo update-perl-sax-parsers --update
I was even about to post that as a patch for the debian install scripts. And then Galen told mtompset and I that the new MARC::File::XML version didn't rely on SAX anymore, so we wouldn't need to do that. If that solves the whole SAX parser problem I'd ask Robin to add the latest version to our repos and remove any reference to this from the (3.12.x onwards) stable releases docs. The question would be: is this (handling MARCXML) the only piece of code that depends on properly set the SAX parser? BTW, I have to insist that IMHO all the install-related documentation should refer to the stable branches and avoid confusing the users. So, until we make a desicion on this we should not make references to things we do for the current master. So, there are few questions:
1) Is this still an issue?
I think it is, and went unnoticed a while ago, for packages.
2) If so, how do we solve it best?
+1 for pushing MARC::File::XML into our repo, if there are no others pieces of code that rely on having the expected SAX parser set as default; in which case I'd just add the referred lines to the docs so packages users set the Debian/Ubuntu SAX parser properly. 3) If not, why is it no longer an issue?
I hope it isn't. Regards To+ -- Tomás Cohen Arazi Prosecretaría de Informática Universidad Nacional de Córdoba ✆ +54 351 4333190 ext 13168 GPG: B76C 6E7C 2D80 551A C765 E225 0A27 2EA1 B2F3 C15F
Greetings, Let’s splice this comment off from Tomas:
BTW, I have to insist that IMHO all the install-related documentation should refer to the stable branches and avoid confusing the users. So, until we make a decision on this we should not make references to things we do for the current master.
We have packages, tarball, git, and wiki. I think INSTALL.{OS} should refer to the branch/tgz for which it is in. If you download a 3.12.x tarball, you aren’t expecting to get 3.14.x or master instructions. You are expecting 3.12.x instructions. If you branch to v3.10.x in git, you aren’t expecting to get master instructions either, but rather 3.10.x instructions. If you do a package installation, you probably are looking at the wiki, and are likely expecting instructions matching the current stable version. This, by the way, led me to try to find installation instructions for packages: cd /usr/share/docs/koha-common/ zcat ... | less Where ... is one of the release notes points to: http://wiki.koha-community.org/wiki/Installation_Documentation This was a little on the ugly side. I cleaned it up a bit. It also points to the INSTALL.{OS} file in the tarball. Anyways, I think that covers all the cases. Comments? GPML, Mark Tompsett
Greetings, tcohen wrote:
... Galen told mtompset and I that the new MARC::File::XML version didn't rely on SAX anymore, so we wouldn't need to do that. If that solves the whole SAX parser problem I'd ask Robin to add the latest version to our repos
+1 to hosting the latest version on the repo, so it will get auto-magically picked up. Side comment: It’s in Saucy, but not Precise, for Ubuntu. tcohen wrote:
and remove any reference to this from the (3.12.x onwards) stable releases docs.
Yes. Once the package is hosted, most definitely this. +1 for simplified documentation. GPML, Mark Tompsett
Tomas Cohen Arazi schreef op di 05-11-2013 om 16:23 [-0200]:
+1 for pushing MARC::File::XML into our repo
The problem is it fails to build: Checking if your kit is complete... Looks good 'CREATE_PACKLIST' is not a known MakeMaker parameter name. only nested arrays of non-refs are supported at /usr/share/perl/5.10/ExtUtils/MakeMaker.pm line 664 dh_auto_configure: perl Makefile.PL INSTALLDIRS=vendor create_packlist=0 returned exit code 2 make: *** [build] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 debuild: fatal error at line 1325: dpkg-buildpackage -rfakeroot -D -us -uc failed it might just be that my build environment needs to be upgraded, I'll have a look at that today hopefully. -- Robin Sheat Catalyst IT Ltd. ✆ +64 4 803 2204 GPG: 5FA7 4B49 1E4D CAA4 4C38 8505 77F5 B724 F871 3BDF
Hi, On Tue, Nov 5, 2013 at 5:31 PM, Robin Sheat <robin@catalyst.net.nz> wrote:
it might just be that my build environment needs to be upgraded, I'll have a look at that today hopefully.
That would be my suspicion, as the current version is successfully packaged for Jessie: http://packages.debian.org/jessie/libmarc-xml-perl Regards, Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org
Robin Sheat schreef op wo 06-11-2013 om 11:31 [+1300]:
it might just be that my build environment needs to be upgraded, I'll have a look at that today hopefully.
It was, and I did, and it worked. MARC::File::XML 1.0.1 is now in the repo. -- Robin Sheat Catalyst IT Ltd. ✆ +64 4 803 2204 GPG: 5FA7 4B49 1E4D CAA4 4C38 8505 77F5 B724 F871 3BDF
Great news on all this.. Just wanted to thank Robin for stepping up to the plate so quickly to get it in his repository after the discussion too. On 5 Nov 2013 23:15, "Robin Sheat" <robin@catalyst.net.nz> wrote:
Robin Sheat schreef op wo 06-11-2013 om 11:31 [+1300]:
it might just be that my build environment needs to be upgraded, I'll have a look at that today hopefully.
It was, and I did, and it worked. MARC::File::XML 1.0.1 is now in the repo.
-- Robin Sheat Catalyst IT Ltd. ✆ +64 4 803 2204 GPG: 5FA7 4B49 1E4D CAA4 4C38 8505 77F5 B724 F871 3BDF
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
participants (5)
-
Galen Charlton -
Mark Tompsett -
Martin Renvoize -
Robin Sheat -
Tomas Cohen Arazi