[Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976

Francois Charbonnier <francois.charbonnier at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |francois.charbonnier at biblib
                   |                            |re.com

--- Comment #16 from Francois Charbonnier <francois.charbonnier at biblibre.com> ---
I'm not sure I have been able to reproduce this bug. I didn't know the set up
so, here are the set ups I used to test this :

The count of "Holds allowed" within the circulation matrix (Library / Category
code / Item type) is :
All / All / All = 3
All / Librarian / Book = 3
Library A / All / All = 3
Library A / Librarian / Book = 3

I worked with 4 system preferences :
* maxreserves
* item-level_itypes
* OPACItemHolds
* ReservesControlBranch

The maxreserves syspref is set up to :
maxreserves = 4

Then I tried every set up possible with the three other sysprefs.

I worked with 4 differents items that have :
biblioitems.itemtype = Book
items.itype = Book

The patron I used to place hold is a Librarian from Library A.

When I tested the set ups with OPACItemHolds = yes, every holds placed were on
the item level. 
If OPACItemHolds was set up to "no", every holds placed were on the biblio
level.

What I noticed is that :
* if koha knows the patron category code, the patron or the item library and
the itemtype, the limit used is the one from the circulation matrix _BUT_ I
have the wrong message : "Sorry, none of these items can be placed on hold". I
should have "Sorry, you cannot place more than X holds."

* if koha doesn't know the item's library ou the item's item type, I can't
place more than 4 holds. So the limit comes from the maxreserves syspref. It's
logical but I think, we should use the "default" rule from the circulation
matrix instead to be more flexible. The maxreserves syspref should be used only
when nothing else apply. Or maybe, we could get rid of the maxreserves syspref,
saying that the default rule (Library =all / Category code = all / Item type =
all) is the one koha should use when nothing apply. Since, the documentation
says this rule is required, I think it would logical to give it a use.

Set ups and test results :

1/
item-level_itypes = biblio
OPACItemHolds = no
ReservesControlBranch = patron's branch
-> it looks like it works but I have the wrong message "Sorry, none of these
items can be placed on hold". I should have "Sorry, you cannot place more than
X holds."

2/
item-level_itypes = item
OPACItemHolds = no
ReservesControlBranch = patron's branch
-> The control looks like it comes from "maxreserves".

3/
item-level_itypes = item
OPACItemHolds = yes
ReservesControlBranch = patron's branch
-> it looks like it works but I have the wrong message "Sorry, none of these
items can be placed on hold". I should have "Sorry, you cannot place more than
X holds."

4/
item-level_itypes = biblio
OPACItemHolds = no
ReservesControlBranch = item's branch
-> The control looks like it comes from "maxreserves".

5/
item-level_itypes = biblio
OPACItemHolds = yes
ReservesControlBranch = item's branch
-> it looks like it works but I have the wrong message "Sorry, none of these
items can be placed on hold". I should have "Sorry, you cannot place more than
X holds."

6/
item-level_itypes = item
OPACItemHolds = yes
ReservesControlBranch = item's branch
-> it looks like it works but I have the wrong message "Sorry, none of these
items can be placed on hold". I should have "Sorry, you cannot place more than
X holds."

7/
item-level_itypes = biblio
OPACItemHolds = yes
ReservesControlBranch = patron's branch
-> it looks like it works but I have the wrong message "Sorry, none of these
items can be placed on hold". I should have "Sorry, you cannot place more than
X holds."

8/
item-level_itypes = item
OPACItemHolds = no
ReservesControlBranch = item's branch
-> The control looks like it comes from "maxreserves".

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.