[Koha-bugs] [Bug 7872] C4::Items should use C4::Koha methods instead of duplicating SQL queries

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7872

--- Comment #13 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to comment #10)
> (In reply to comment #6)
> > (In reply to comment #5)
> > 
> > > LIMIT 1 is not needed since adding framework to WHERE always returns single
> > > row and it's more correct.
> > 
> > Why more correct ? I don't understand.
> > For me, LIMIT 1 should be used if we want only a unique row. I think it can
> > increase performance (I agree with you, it is negligible).
> 
> Actually a where on an indexed column is a lot faster than using limit,
> explain is a good tool for looking at the query plan to see how mysql is
> optimising the query. There is a whole project of sql optimisation we could
> do by checking some of our more used queries.

Site comment: investigating DBI, we've found that all handlers are
automatically closed when a query has returned all results. If plan not to
fetch all results, then you must explicitely close $sth, or you may have some
useless memory consumption

-- 
You are receiving this mail because:
You are watching all bug changes.