[Koha-bugs] [Bug 7470] Babeltheque improvement and social networks links (like, +1, ...)

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470

--- Comment #15 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to comment #13)
> QA Comments: Larger patch. Looks good in general. Controlled by several
> prefs. So does not hurt anyone who does not use it. Only miss comments from
> current Babeltheque users.
> 
> 
> Resolved Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
> Trailing whitespace at apply.
trivial conflict, resolved.

> Double dbrev in updatedatabase: please combine into one. Paul could do that
> at pushing time..
I prefer to have 2 dbrevs: the babeltheque stuff is specific to babelio
customers, probably only french libraries
The other (social networks) is related to having links to "like", "+1",... that
are a different feature. So having 2 DBrevs will enforce the visibility of the
2nd feature.
> As it appears, the backquotes are not liked by PostgreSQL. Not a blocker
> until now? Lots of these in updatedatabase..
good point. I've removed them in the commit

> update_data: say "$i data insered or updated"; Where does this output go to?
> Note spelling error too ;)
The update_data script is called by a cronjob, that's the result of the cron
(with the generated file), so no need to worry here
I've fixed the typo in the commit.

> get_report: This seems quite a job. Just curiosity: but how often would you
> like to do that in a cron job?
for our customers, it will be once a week. We have 2 medium size catalogue (300
000 items) running it for now. Maybe for AixMarseille (1 million !) that will
even be less frequent.

> update_social_data.pl: /tmp is probably ok for rights, but could be an
> issue. bunzip2 will not be in /bin for every linux distro.
I think you're right. Jonathan, I think having the patch in the cron PATH is
something we can request. Thus, just calling bunzip2 should be OK.
You could also try to guess the patch by testing some common ones. There's
something like that in rebuild_zebra.pl, to find zebraidx

> opac-detail.tt: https://apis.google.com/js/plusone.js: Do you need to
> include this js if you do not use this feature? Probably not.
> <a href="mailto:ADRESSE?subject=TO READ : [% title %]>: Does not look great.
> 
you're right Marcel. Jonathan, could you provide a follow-up

> In conclusion:
> May need some followups. But have no objection to push it further.

So I push it now ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.