[Koha-bugs] [Bug 8849] New: Error log generated when not a demo system

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8849

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8849
                CC: gmcharlt at gmail.com
          Assignee: koha-bugs at lists.koha-community.org
           Summary: Error log generated when not a demo system
          Severity: trivial
    Classification: Unclassified
                OS: All
          Reporter: mtompset at hotmail.com
          Hardware: All
            Status: NEW
           Version: rel_3_8
         Component: System Administration
           Product: Koha

As a result of:
[Mon Oct 01 15:28:59 2012] [error] [client 192.168.100.2] [Mon Oct  1 15:28:59
2012] marctagstructure.pl: Use of uninitialized value in numeric eq (==) at
/usr/share/koha/intranet/cgi-bin/admin/marctagstructure.pl line 152.
in Koha 3.8.5 this patch was generated.

The line reads
     unless (C4::Context->config('demo') == 1) {
which produces an error long entry while tweaking frameworks. It should read:
     unless (defined(C4::Context->config('demo')) &&
C4::Context->config('demo') == 1) {
-- though this will still generate an error if the value isn't numeric. I'm
going to assume that whoever does use it, will use it correctly.

My understanding is that this value must be set to 1 in koha-conf.xml to
prevent writing out MARC Framework changes (adds or modifies). However, since
'demo' is not defined in the default koha-conf.xml, this generates an error.

This feature is not documented anywhere, as far as I know. Though 'demo' code
does seem to exist in a couple places in Koha.

Patch to follow.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.