[Koha-bugs] [Bug 8849] Error log generated when not a demo system

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8849

--- Comment #1 from M. Tompsett <mtompset at hotmail.com> ---
It would seem that admin/auth_tag_structure.pl,
admin/marc_subfields_structure.pl, admin/marctagstructure.pl, and
admin/auth_subfields_structure.pl all need their condition revised.

However, since I only found marctagstructure.pl in the error logs and since I
can reproduce it, only marctagstructure.pl will be fixed. However, not with a
==1 or eq 1, but by removing the operator portion completely as is elsewhere.

This is a grep from 3.8.x:
$ grep "'demo'" `find .`
./admin/auth_tag_structure.pl:    unless (C4::Context->config('demo') eq 1) {
./admin/auth_tag_structure.pl:  unless (C4::Context->config('demo') eq 1) {
./admin/marc_subfields_structure.pl:            unless (
C4::Context->config('de                                                        
                               mo') eq 1 ) {
./admin/marc_subfields_structure.pl:    unless ( C4::Context->config('demo') eq
                                                                               
        1 ) {
./admin/preferences.pl:    unless ( C4::Context->config( 'demo' ) ) {
./admin/marctagstructure.pl:    unless (C4::Context->config('demo') == 1) {
./admin/marctagstructure.pl:    unless (C4::Context->config('demo') == 1) {
./admin/auth_subfields_structure.pl:                    unless
(C4::Context->con                                                              
                         fig('demo') eq 1) {
./admin/auth_subfields_structure.pl:    unless (C4::Context->config('demo') eq
1                                                                              
         ) {
./admin/systempreferences.pl:        unless ( C4::Context->config('demo') ) {
./admin/systempreferences.pl:        unless ( C4::Context->config('demo') ) {
./admin/systempreferences.pl:        unless ( C4::Context->config('demo') ) {
./admin/systempreferences.pl:        unless ( C4::Context->config('demo') ) {
./C4/Auth.pm:    if (   $userid && $userid eq 'demo'
./C4/Auth.pm:        && "$password" eq 'demo'
./C4/Auth.pm:        && C4::Context->config('demo') )
./C4/Auth.pm:    elsif ( $userid eq 'demo' && C4::Context->config('demo') ) {
./debian/scripts/koha-run-backups:# - dump all sites, except one called 'demo'
./svc/config/systempreferences:    unless ( C4::Context->config('demo') ) {
./svc/config/systempreferences:    unless ( C4::Context->config( 'demo' ) ) {
./installer/InstallAuth.pm:        && $userid     eq 'demo'
./installer/InstallAuth.pm:        && "$password" eq 'demo'
./installer/InstallAuth.pm:        && C4::Context->config('demo') )

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.