[Koha-bugs] [Bug 10639] Circular dependencies cause inventory.pl to fail when returning items

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10639

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Nevermind...I thought that I had tested this in the master branch, but
apparently I had not. Apparently, I had actually just eyeballed the master code
that I expected to be different (in Circulation.pm) and seeing it was the
same...decided that was enough.

In fact, Jared Camins-Esakov removed this particular circular dependency back
in 3.08.01 with Bug 7847: OPAC search dies with Plackthis (commit
c97e0c76739b0624359feb47ee0573ebc46b8409).

In order to do so, he removed the "use C4::Search" declaration at the top of
C4::Items and instead used "require C4::Search" in the subs that needed it, and
then used fully qualified sub names (since they are required when using
"require" rather than "use").

Yay, Jared!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.