[Koha-bugs] [Bug 10639] Circular dependencies cause inventory.pl to fail when returning items

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10639

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
That said, I think this is something that developers should keep in mind going
forward...

Chris Cormack said that the ideal method should be as follows:

1) Export subs using the EXPORT_OK array
2) Import subs using "use C4::Module qw (sub1 sub2)"

Jared Camins-Esakov also mentioned:

1) In addition to the above, ff there is going to be any confusion, fully
qualify the name (e.g. Add the C4::Module:: notation to the front of your
imported sub when you're calling it).

2) "A require and fully-qualified call will at least make it easy to recognize
problems."

My two cents:

I wonder if we should decide on the best method and put it in the Coding
Guidelines?

Should we always fully qualify subroutine names?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.