[Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |srdjan at catalyst.net.nz

--- Comment #2 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
There are some things that would be nice to address:

1. if ( defined $delay && $delay >= 0 ), elsif ( defined $delay && $delay < 0 )
is too much,
if ( $delay >= 0 ), elsif ( $delay < 0 )
should do

2. Around line 137 - closing { for elsif ( defined $delay && $delay < 0 ) -
identation becomes broken (probably tabs need replacing with blank spaces)

3. if ( defined $estimateddeliverydateto ) {} elsif ( !defined
$estimateddeliverydateto ) {}
should probably be
if ( defined $estimateddeliverydateto ) {} else {}

-- 
You are receiving this mail because:
You are watching all bug changes.