[Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in C4::Bookseller.pm has some incoherences

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641

kenza <kenza.zaki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19942|0                           |1
        is obsolete|                            |

--- Comment #3 from kenza <kenza.zaki at biblibre.com> ---
Created attachment 19975
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19975&action=edit
Bug 10641 - GetBooksellerWithLateOrders in C4::Bookseller.pm has some
incoherences

This patch fixes some incoherences of the routine GetBooksellerWithOrders.
Now it considers the field $estimateddeliverydateto and it replaces it by now()
only if it is undef.
More it doesn't test if $aqbookseller.deliverytime is not Null anymore but if
$deliverytime = null or undef, it replaces it by 0.
It also verifies if $delay is >= 0 and return undef if it is a negative value.

To Test:
prove t/db_dependent/Bookseller.t
t/db_dependent/Bookseller.t ..
[Some warnings about uninitialized values]
WARNING: GetBooksellerWithLateOrders is called with a negative value at
C4/Bookseller.pm line 135.
t/db_dependent/Bookseller.t .. ok
All tests successful.

-- 
You are receiving this mail because:
You are watching all bug changes.