[Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320

--- Comment #3 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
A few remarks (you may choose to ignore):

_request():
* you are only logging die() case, it may be good to log $response->as_string
if !$response->success.

GetOverDriveToken():
* m!! (or similar) is a tad easier to read then m,,
* in warn $contents->{'error_description'} it is assumed that from_json() was
successful

Please let me know if you want to leave as is, I'll sign it off.

-- 
You are receiving this mail because:
You are watching all bug changes.