[Koha-bugs] [Bug 10363] There is no package for authorised values.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |srdjan at catalyst.net.nz

--- Comment #4 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Jonathan,

I'm not sure if there's a consensus re constructors in the Koha namespace and
use of Class::Accessor. I believe it is rarely necessary to provide new() in
those cases.

I suggest:
* remove new() constructors all together, Koha::AuthorisedValue->new({av =>
$av}) is unnecessary cause it is equivalent to Koha::AuthorisedValue->new($av}
* upgrade fetch(key) to constructors, passing the key values; this way
Koha::AuthorisedValues->new() becomes Koha::AuthorisedValues->fetch()
* if you need to reload(), make those methods, and make reload() and fetch()
call _fetch(key)

In general, has there been a discussion on using DBIx::Class or similar?

-- 
You are receiving this mail because:
You are watching all bug changes.