[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #62 from Kyle M Hall <kyle at bywatersolutions.com> ---
It looks like there is a value conflict here. The database update is assuming
the syspref value of '1' should be converted to 'yes', but the code is still
assuming it that it is '1'. 

I think leaving 'no' as an empty value makes the template code cleaner, but I
think it would be better to keep the alteration of '1' to 'yes'. However, it's
probably much easier to alter the database update, so I wouldn't fail qa just
for keeping '1' instead of 'yes'.

I hope this makes sense!

-- 
You are receiving this mail because:
You are watching all bug changes.