[Koha-bugs] [Bug 8190] Add a logging module to Koha

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190

--- Comment #94 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Some QA observations:

The first patch commit message should preferably be edited.
Since we initialize the logger in Auth.pm, you do not need:
use Koha::Utils::Logger qw/$log/;
$log = Koha::Utils::Logger->new;
Just say: $log= C4::Context->logger;
(This was actually the reason for the last followup.)
Will take the liberty now to edit these comments. Forgive me for that..

The first patch seems to delete a SetVersion line in updatedatabase for an
older dbrev (3.9.0.45?). This is a blocker. Will amend this one if nothing more
follows.

The hardcoded 5 in Koha::Utils::Logger in new routine is not very nice :)
Strange, because it was a constant in earlier patch than patch 5.

Thanks for adding the alert level. When looking trough the code I still noticed
a mention of 7 levels instead of 8 now.

Another set of patches coming..

-- 
You are receiving this mail because:
You are watching all bug changes.