[Koha-bugs] [Bug 5349] Moving an order

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #66 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Julian,

It looks to me like the design of internalnotes is not a good idea:

+    $order->{'internalnotes'} = "Transfered from $booksellerfromname on
$today";
+    $sth->execute("Cancelled and transfered to $booksellertoname on $today",
$ordernumber);

This won't ever be translatable. We should never store composed English strings
in the database. 

Also I think that for a column named internalnotes I would expect a different
use. Like a internal note that a librarian can set and edit. 

Other solutions I can think of are to store the transferdate and the original
vendor in separate columns and compose the message in the templates. 

Or it might be worth having a column for a cancellation reason that is filled
via an authorized value list. 

This way we could also give other reasons, like out of print, etc. But the date
and vendor would still have to be stored somewhere else if you want to keep
that information. Maybe action_log?

Maybe a quick discussion about this could help to find the best solution.

-- 
You are receiving this mail because:
You are watching all bug changes.