[Koha-bugs] [Bug 9811] Patrons search improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I really like the idea to use datatables for the patron search page, but I
found a few problems with the patches.

1) The patches don't pass the QA script:

* koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc               FAIL
forbidden patterns          FAIL
The patch introduces a forbidden pattern: tabulation character (95)
The patch introduces a forbidden pattern: tabulation character (94)

* C4/Utils/DataTables/Members.pm                                           FAIL
pod                         OK
forbidden patterns          OK
valid                       FAIL
Use of qw(...) as parentheses is deprecated 

2) The new C4/Utils/DataTables/Members.pm adds mysqlisms:

my $select = "SELECT SQL_CALC_FOUND_ROWS
"SELECT FOUND_ROWS()";

-- 
You are receiving this mail because:
You are watching all bug changes.