[Koha-bugs] [Bug 10533] basketgroup js functions should in a separated js file

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Apr 11 19:08:30 CEST 2014


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533

--- Comment #14 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to M. de Rooy from comment #12)
> I looked at the move of this code from one file to the other. And made a
> quick compare between what you deleted and what you created in a git format
> file.
> Unfortunately this compare was not very helpful. Too much differences
> (including spacing etc.) Makes it harder to verify what happens here..

Indeed.  However, with some use of diff -bw to compare the old acq.js, the new
acq.js, and basketgroup.js (and with testing of the acq pages, of course), I
was able to convince myself that the patch implements a clean move of those
functions.

Plus, it has the benefit of sticking the last active use of YUI by the staff
interface in one file.

Signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list