[Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl and rename it in basketgroup.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25367|0                           |1
        is obsolete|                            |

--- Comment #5 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 27037
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27037&action=edit
Bug 11433 - Remove attachbasket op value in basket.pl and rename it in
basketgroup.pl

This patch cleans code in basket.pl, basketgroup.pl and basketgroup.tt
Not absolutely needed, but makes further improvements easier

'attachbasket' is used in basket.pl and basketgroup.pl as a value of $op
In basket.pl, some code is supposed to be executed if $op eq 'attachbasket'.
But it is never the case (grep attachbasket * -r), so this condition must be
removed.
In basketgroup.pl, the description of 'attachbasket' value in comments is
wrong, and the name is misleading (this value of $op is ONLY used when someone
clic on 'Save' button on a basketgroup page). So 'attachbasket' should be
renamed.

This patch
- removes code related to 'attachbasket' in basket.pl
- rename 'attachbasket' to 'save' in basketgroup.pl and basketgroup.tt
- fixes some comments related to 'attachbasket' and 'mod_basket' in
basketgroup.pl

No functional change expected.
Regression test only :
Make a complete acquisition process, from the creation of a basket to the
closure of a basketgroup, and check everything is OK
On a basket page, try to change the basketgroup it belongs to, and check
everything is OK
On a basketgroup page, try to edit the content of a basketgroup (put a new
basket in it, change the deliverybranch...), and check everything is OK
On a basketgroup page, try to reopen a closed basketgroup, and close an open
basketgroup, and check everything is OK

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.