[Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |dcook at prosentient.com.au

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
The logic in this patch makes little sense, and is invalid XSL in some cases. 

In regards to the XSL, there are two <xsl:otherwise> elements in the
<xsl:choose> element. There should be only one as it is the default "otherwise"
condition. The first "otherwise" condition in these XSLTs is useless, so I'd
just delete it all together.

The test for "$UseControlNumber = '0'" is counter-productive in that it
functions as a de facto "otherwise" which means the test for
"marc:subfield[@code='0']" will never be triggered.

The final "otherwise" is also useless as it is missing its href attribute. 

The tests for "marc:subfield[@code='t']" are problematically placed in almost
every case well.  

Rather than salvage this patch, I would suggest starting again with the
existing 773 as a model.

I added the 787 to our local XSLT a while ago. Perhaps I'll add an alternative
patch when I work on porting some other customizations.

-- 
You are receiving this mail because:
You are watching all bug changes.