[Koha-bugs] [Bug 11814] Serial statuses should be stored in constants

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
I really like the idea of this patch! It seems like it would make it a lot
easier to do development on serials this way!

I'm curious about your follow-up. Are there are a few more places that the
constants could be used in that SQL?

"AND (serial.STATUS IN ($missing_statuses_string) OR ((planneddate < now() AND
serial.STATUS =1) OR serial.STATUS = 3 OR serial.STATUS = 7))"

Couldn't 1, 3, and 7 be exchanged a variable containing the value from the
constant? 

I don't use serials very often, so I might let someone else with more
experience with the workflow try this one out.

-- 
You are receiving this mail because:
You are watching all bug changes.