[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23457|0                           |1
        is obsolete|                            |

--- Comment #17 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 25879
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25879&action=edit
[SIGNED OFF] Bug 5010: Fix incomplete links in carts and lists sent from the
staff client

While the list email hardcoded http:// in front of the URL, the cart email
was missing http(s)://. As there seems to be no reliable way to determine
in staff if the OPAC is using SSL or not, this patch introduces a new
system preference: PublicCatalogUsesSSL.

To test:
- Create a list
- Send yourself the list from the staff interface
- Verify that the links are http://<OPACBaseURL>
- Put some records into your cart
- Send yourself the cart from the staff interface
- Verify that the links are missing http(s):// in front of them
- Apply patch
- Run database update
- Verify that the default setting for PublicCatalogUsesSSL is 'doesn't use'
- Resent both emails
- Verfiy the catalog links are now both http:// links
- Change system preference setting to 'uses'
- Resent both emails
- Verify the catalog links are now https:// links

NOTE: My cart didn't have a 'In online catalog:' line on master.
      My list had http:// on master.
      System preference affected both cart and list sending.
      System preference necessary, because there is no way to
       determine http or https in the middle of an email.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.