[Koha-bugs] [Bug 12291] remove acronym for CAS

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12291

--- Comment #1 from Fridolin SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 28347
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28347&action=edit
Bug 12291 - remove acronym for CAS (bootstrap)

The HTML tag acronym is obsolete for HTML5 and also complicates translation.

In sources :
  <p>If you have a <acronym title="Central Authentication
Service">CAS</acronym> account,
It generates :
  msgid "If you have a "
  msgid "Central Authentication Service"
  msgid "account, %s please "
This is difficult to translate correctly because strings are splitted.
For example in French, the translation is actually :
  msgid "Si vous avez un "
  msgid "Central Authentication Service (Service d'Identification Centralisé)"
  msgid "compte, %s s'il vous plait "
It generates :
  <p>Si vous avez un <acronym title="Central Authentication Service (Service
d'Identification Centralisé)">CAS</acronym> compte, %s s'il vous plait.
It should be :
  <p>Si vous avez un compte <acronym title="Central Authentication Service
(Service d'Identification Centralisé)">CAS</acronym>, %s s'il vous plait.

This patch removes the acronym tag and moves the title attribute to the h4 tag.

Test plan :
- Enable OPAC bootstrap theme
- Enable casAuthentication
- Go to login page /cgi-bin/koha/opac-user.pl
=> Without patch you see "If you have a CAS account", CAS is a acronym tag.
=> With patch you see "If you have a CAS account" without acronym tag and "CAS
login" has a title "Login via Central Authentication Service"

-- 
You are receiving this mail because:
You are watching all bug changes.