[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651

--- Comment #16 from Rafal Kopaczka <rkopaczka at afm.edu.pl> ---
(In reply to Owen Leonard from comment #15)
> This isn't working for me. When I select 4 titles in the holds queue to
> print, the resulting printout says:
> 
> Reserve not foundReserve not foundReserve not foundReserve not found
> 
> Looks like reserve_id isn't getting passed to the template?

It says, that "reserve not found", so some id must be passed to script, have
you updated database and re-run build_holds_queue.pl after that? 
Printing from holds queue require reserve_id in tmp_holdsqueue, which is
populated by build holds queue after patch. If this didn't work let me know. 

> 
> Note that the term "hold" should be used instead of "reserve." We only use
> "reserve" in the context of Course Reserves.
> 
> Looks like that text is coming directly from the .pl file. English strings
> should be handled in a way which is translatable, preferably by putting them
> in the template. printslip.tt appears to be capable of handling it already?

printslip.tt only partial can handle this case, since it print "hold not
found", only if slip variable is undef. In case of printing many holds only few
may be not found, while other will define slip. So hold not found info would
not show.
I'll try to figure out some error handling in print for this case.

> 
> Some other suggestions:
> 
> - Leave the header cell in the checkbox column empty. It doesn't
>   need the word "Check."
> - Exclude the checkbox column from being sorted by the table sorter.
> - Add a warning to the user if they click the "Print checked holds"
>   without checking anything.

Will do. 

Thanks for test!

-- 
You are receiving this mail because:
You are watching all bug changes.