[Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Passed QA

--- Comment #16 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #12)
> There is something here I am not so happy with - the test plan tells you
> test one out of 4 notices that are touched by this patch set:
> - notifications about new serial issues
> - claims in serials
> - claims in acq
> 
> I'd love if those could be tested as well. Could a tester take a look at
> these as well please?

I have spent some time on getting that above the water (Dutch expression only?)

With a small test script I managed to generate all four notices in plain text
and html. These two patches are fine.
With the sign-off from Paola and the fairly trivial changes, I take the liberty
to pass QA on them too.
But I definitely agree with Katrin and David that the code around these changes
needs attention :)
I will put some additional comments below.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.