[Koha-bugs] [Bug 12739] SendAlerts function does not take care of "html" format or UTF-8

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12739

--- Comment #17 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
What I found while testing is:

[1] There is no claimissues notice in the system. (The claimacquisition is
created in the installer, the other one is not there.) Bad.
[2] The fact that $type is passed to GetPreparedLetter as module name looks
strange. 
[3] The second parameter of SendAlerts is externalid. In some cases this should
be an id, in other cases an array reference. Does not look good.
[4] For claimacquisition and claimissues, the From address is
userenv->{emailaddress}. This is uncommon.
[5] In the same part of the code, two fetch rows are behind each other without
any testing. If there are no records found, this will generate an error.

If I would look a little bit longer, I would find even more :)

-- 
You are receiving this mail because:
You are watching all bug changes.