[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #31 from Barton Chittenden <barton at bywatersolutions.com> ---
(In reply to Barton Chittenden from comment #30)
> Created attachment 43040 [details] [review]
> [SIGNED-OFF] Bug 14739 - Add several patrons to a new batch will create a
> new batch per patron added
> 
> This patch changes the functionality of adding patrons to patroncard
> batches.  Instead of using only the patron search, there is now a textarea
> which can either be manually populated with borrowernumbers, or can be
> populated using the patron-search
> 
> To test:
> 1 - Create a new patron batch
> 2 - Click the add items button, if there is no data in the borrowrnumber
> form you should get a popup
> 3 - Add items to batch using the popup, borrowernumbers should populate to
> the form
> 4 - Click add items again and items should be added to a new batch
> 5 - Create a new batch
> 6 - Manually enter invalid borrowernumbers to the form
> 7 - Click add items, batch should return empty
> 8 - Manually enter valid borrowernumber
> 9 - Click add items, batch should be updated
> 10 - Edit an existing batch and confirm add items works as above
> 11 - Create a new label batch
> 12 - Click add items with no data, popup item search should appear
> 13 - Adding items by checking boxes or using 'Add' button - they should
> populate the text box on the edit batch page
> 14 - When adding using form the 'Enter by itemnumber' button should be
> marked automatically
> 15 - Submit items and confirm they are added to batch
> 16 - Create a new batch, enter by barcode manually and check 'Enter by
> itemnumber"
> 17 - Click add items, no items should be added
> 18 - Repopulate form with barcodes, check 'Enter by barcode'
> 19 - Click add items, items should be added correctly
> 20 - Test various combinations of radio buttons and numbers and using form
> or not
> 
> Signed-off-by: Barton Chittenden <barton at bywatersolutions.com>

I've tested without error, and I'm signing off, but I know that Jonathan wants
to see if we can replicate the errors that Josef Moravec was seeing, so I'm not
going to set the status of the bug as a whole to 'Signed Off'. This is simply
saying 'the patch works for me'.

-- 
You are receiving this mail because:
You are watching all bug changes.