[Koha-bugs] [Bug 15479] SIPserver rejects renewals for patrons with alphanumeric cardnumbers

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jan 15 19:30:34 CET 2016


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15479

Frédéric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #3 from Frédéric Demians <frederic at tamil.fr> ---
I get the reasoning, and agree with it. Do you think you could cook a unit test
to check this case? A UT which fails without your patch, and succeed with it?

And a minor point of detail: why do you use a function rather than a regex in
your test. For example:

$item->{patron} && $item->{patron} !~ /^$patron_id$/i

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list