[Koha-bugs] [Bug 15479] SIPserver rejects renewals for patrons with alphanumeric cardnumbers

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15479

--- Comment #4 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
(In reply to Frédéric Demians from comment #3)
> I get the reasoning, and agree with it. Do you think you could cook a unit
> test to check this case? A UT which fails without your patch, and succeed
> with it?
> 
> And a minor point of detail: why do you use a function rather than a regex
> in your test. For example:
> 
> $item->{patron} && $item->{patron} !~ /^$patron_id$/i

Readability  it might be to easy for the eye to skip over the regex, and as the
comparison is called twice ensure they both make the same test. Supplementary
patch tests the sub's returns as well as adding basic tests for ILS.pm inteface

-- 
You are receiving this mail because:
You are watching all bug changes.