[Koha-bugs] [Bug 11371] Add a new report : Orders by budget

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 45982
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45982
Bug 11371 - Add a new report : Orders by budget

Review of attachment 45982:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11371&attachment=45982)
-----------------------------------------------------------------

I am not convinced by the new subroutines you add with this patch.
There are usually too specific and could be done with existing subroutines from
C4::Acquisition or C4::Budgets
The main problem is that there is not real test coverage for them.

::: C4/Budgets.pm
@@ +473,5 @@
> +    Description is fetched from aqbudgetperiods, id is compared aqbudgets. (INNER JOIN on budget_period_id)
> +
> +=cut
> +
> +sub GetBudgetPeriodDescription {

This subroutine is too specific.
It could be replaced with
my $budget_period = GetBudgetPeriod( $budget->{budget_period_id} )
my $budget_period_description = $budget_period->{budget_period_description}

-- 
You are receiving this mail because:
You are watching all bug changes.