[Koha-bugs] [Bug 15618] Small typos in system preferences

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Jan 25 06:03:33 CET 2016


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15618

--- Comment #20 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 47148
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47148
Bug 15618: Typos fixed in circulation.pref

Review of attachment 47148:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15618&attachment=47148)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
@@ +161,4 @@
>                choices:
>                    yes: Allow
>                    no: "Don't allow"
> +            - checkouts of items which are on hold to someone else. If allowed do not generate RESERVE_WAITING and RESERVED warning. This allows self checkouts for those items.

"reserved to" is wrong, but I think this should be either "reserved by" (less
change and aligns with RESERVE message portions) or "which are on hold for".

@@ +278,4 @@
>          -
>              - "Restrict patrons with the following target audience values from checking out inappropriate materials:"
>              - pref: AgeRestrictionMarker
> +            - "E.g. Enter target audience keyword(s) split by | (pipe) FSK|PEGI|Age| (No white space near |). Be sure to map agerestriction in Koha to MARC mapping (e.g. 521$a). A MARC field value of FSK 12 or PEGI 12 would mean: 'Borrower must be 12 years old'. Leave empty to not apply an age restriction."

I was noticing 856u in another patch on this bug report. Are we doing 856u or
856$u? We have 521$a here. Should it be 521a?

@@ -365,5 @@
>                choices:
> -                  confirm: "require confirmation"
> -                  alert: "display a message"
> -                  nothing : "do nothing"
> -            - .

I like this '.' removal and placing at the end of the strings.

@@ +523,5 @@
>              - pref: emailLibrarianWhenHoldIsPlaced
>                choices:
> +                  yes: Do
> +                  no:  "Don't"
> +            - "send an email to the Koha administrator email address whenever a hold request is placed."

"Send" "Don't send"? I don't see why this change is necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list