[Koha-bugs] [Bug 16819] C4::Members::DelMember should use Koha::Holds to delete holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16819

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 53031
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53031
[SIGNED-OFF]Bug 16819: C4::Members::DelMember should use Koha::Holds to delete
holds

Review of attachment 53031:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=16819&attachment=53031)
-----------------------------------------------------------------

::: C4/Members.pm
@@ +1662,5 @@
>      #warn "in delmember with $borrowernumber";
>      return unless $borrowernumber;    # borrowernumber is mandatory.
> +    # Delete Patron's holds
> +    my @holds = Koha::Holds->search({ borrowernumber => $borrowernumber });
> +    map { $_->delete } @holds;

I'd have written that `$_->delete for @holds`. Since map is supposed to return
something I guess it can perturb a new developer. Do you agree?

-- 
You are receiving this mail because:
You are watching all bug changes.