[Koha-bugs] [Bug 16836] Document unused parameters of SearchAuthorities

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16836

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Héctor Eduardo Castro Avalos from comment #2)
> If you query $ git grep 'SearchAuthorities'
> 
> 
> There are some lines that use the two parameters, maybe exist more:
> 
> 
> authorities/auth_finder.pl:      SearchAuthorities( \@marclist, \@and_or,
> \@excluding, \@operator, \@value,
> authorities/authorities-home.pl:    #my ( $results, $total ) =
> SearchAuthorities(
> authorities/ysearch.pl:    my ( $results, $total ) = SearchAuthorities(
> \@marclist, \@and_or, \@excluding, \@operator, \@value, $startfrom *
> $resultsperpage, $resultsperpage, $authtypecode, $orderby );
> cataloguing/value_builder/unimarc_field_210c.pl:###TODO To rewrite in order
> to use SearchAuthorities
> cataloguing/value_builder/unimarc_field_210c.pl:        my ($results,$total)
> = SearchAuthorities( \@tags,\@and_or,
> cataloguing/value_builder/unimarc_field_225a.pl:    my ($results,$total) =
> SearchAuthorities( \@tags,\@and_or,
> 
> Regards

Hello Hector,

That is true. The parameters are passed to the routine, but they actually do
nothing. This patch makes that fact more visible without having to change all
calls of the routine. Note that this allows someone to adjust the routine to do
something useful with these parameters.

Marcel

-- 
You are receiving this mail because:
You are watching all bug changes.