[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
  Attachment #63322|0                           |1
        is obsolete|                            |
  Attachment #63323|0                           |1
        is obsolete|                            |
  Attachment #63324|0                           |1
        is obsolete|                            |
  Attachment #64304|0                           |1
        is obsolete|                            |
  Attachment #64305|0                           |1
        is obsolete|                            |
  Attachment #64306|0                           |1
        is obsolete|                            |

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 64304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64304&action=edit
Bug 13452: 'Average loan time' report to obey item-level_itypes preference

Fixes the 'Average loan time' report so that the system
preference setting item-level_itypes is taken into account.

Before the patch, the report was always using the biblio
level itemtype. With the patch, it will depend on the pref
setting.

To test:
- Run various reports, compare results with both
  possible pref settings
- Try limiting your search in various ways, especially
  on a specific itemtype
- Make sure you switch checkboxes in testing,
  using itemtype as the row or as the column

Notes:
- Filtering on a specific itemtype on master was not working
  if the itemtype was chosen as column. The patch should fix that.
- Fixes headings and breadcrumbs so that the name of the report
  is the same as on the reports start page

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 64305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64305&action=edit
Bug 13452: Fix for plack

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 64306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64306&action=edit
Bug 13452: 'Average loan time' report to obey item-level_itypes preference

Fixes the 'Average loan time' report so that the system
preference setting item-level_itypes is taken into account.

Before the patch, the report was always using the biblio
level itemtype. With the patch, it will depend on the pref
setting.

To test:
- Run various reports, compare results with both
  possible pref settings
- Try limiting your search in various ways, especially
  on a specific itemtype
- Make sure you switch checkboxes in testing,
  using itemtype as the row or as the column

Notes:
- Filtering on a specific itemtype on master was not working
  if the itemtype was chosen as column. The patch should fix that.
- Fixes headings and breadcrumbs so that the name of the report
  is the same as on the reports start page

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 64307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64307&action=edit
Bug 13452: 'Average loan time' report to obey item-level_itypes preference

Fixes the 'Average loan time' report so that the system
preference setting item-level_itypes is taken into account.

Before the patch, the report was always using the biblio
level itemtype. With the patch, it will depend on the pref
setting.

To test:
- Run various reports, compare results with both
  possible pref settings
- Try limiting your search in various ways, especially
  on a specific itemtype
- Make sure you switch checkboxes in testing,
  using itemtype as the row or as the column

Notes:
- Filtering on a specific itemtype on master was not working
  if the itemtype was chosen as column. The patch should fix that.
- Fixes headings and breadcrumbs so that the name of the report
  is the same as on the reports start page

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 64308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64308&action=edit
Bug 13452: Fix obvious issues in issues_avg_stats.pl

- Remove joins with issuingrules which are not needed
- Fix the SQL query so that $weight is now the value of COUNT(*) instead
  of a timestamp
- QA fix: '$column eq $itype' instead of '$column =~ $itype' (same for
  $line)

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 64309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64309&action=edit
Bug 13452: Fix for plack

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.