[Koha-bugs] [Bug 17710] C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63771|0                           |1
        is obsolete|                            |
                 CC|                            |kyle at bywatersolutions.com
             Status|Signed Off                  |Passed QA

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 64326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64326&action=edit
Bug 17710 - C4::Matcher::get_matches and C4::ImportBatch::GetBestRecordMatch
should use same logic

C4::ImportBatch::GetBestRecordMatch uses SQL to sort by score descending
then candidate_match_id descending. With C4::Matcher::get_matches, I
implement the same sort but use Perl code to do it, since we're sorting
search results.

It's a simple change, but it's in a big block of code, so I don't have
unit tests.

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.