[Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|enhancement                 |major
            Summary|Enabling syspref            |BakerTaylorEnabled is not
                   |'BakerTaylorEnabled' causes |plack safe in reading
                   |software error              |history at the OPAC

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Aleisha,
I agree that there is something wrong, but the test plan is not enough.

There are several things wrong:
- import must be done at the beginning of the module
- import must not be dependent of syspref in begin blocks

What's happen is that Plack run all BEGIN blocks and it starts, and that the
only time they are evaluated.
That means that if you start plack and your pref BakerTaylorEnabled is
disabled, the require+import will not be done.
If you then enable the pref (and not restart plack of course) and access the
opac-readingrec view, it will explode.

-- 
You are receiving this mail because:
You are watching all bug changes.