[Koha-bugs] [Bug 20836] debian/control.in cleanup

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20836

--- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> ---
(In reply to Tomás Cohen Arazi from comment #2)
> I clearly don't understand this line in the koha-common section of
> debian/control:
> 
> Depends: ${misc:Depends}, ${koha:Depends},

${misc:Depends} is used by debhelper, see below for ${koha:Depends}.


> as I don't understand how koha-common pulls all its deps, which are not in
> master's debian/control. 

koha-perldeps is the same as the perl part of build-depends. It is generated by
debian/update-control. It includes all perl modules that are required, and the
non-required ones that are available in the system you run the script. So
libwww-youtube-download-perl appears or not, depending on the distribution you
build in. A build in Jessie or Stretch has it, but a build in Wheezy doesn't.

${koha:Depends} is replaced by what debian/bd-to-depends generates. Which is
everything from build-depends minus exceptions. The reason to do this is to
have a shorter file. Which means libwww-youtube-download-perl is in there too,
ever since the official packages were no longer built in Wheezy and nobody ever
complained.

First I thought the Suggests section would magically override it, but it
doesn't. Extracting the deb of koha-common 18.05.00-2 there is
Suggests: mysql-server | virtual-mysql-server, letsencrypt

That was a fun ride with a nice twist. :D


> That said, I think we should add
> libwww-youtube-download-perl to the dependencies (why is it a dependency for
> koha-perldeps and not for koha-common?) I can file a bug for that.

We made libwww-youtube-download-perl optional because it was not available for
Wheezy, which we don't support anymore. It should be mandatory now.
We should remove the useless control.in entry in "Suggests" and set it to
required in PerlDependencies.pm (does not make a difference for the packages
though).

-- 
You are receiving this mail because:
You are watching all bug changes.