[Koha-bugs] [Bug 16739] generate edifact showing on basket groups
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu May 10 16:38:07 CEST 2018
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16739
Owen Leonard <oleonard at myacpl.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
This looks like it's working correctly, but the QA tool has several complaints
about tab indentation. Indentation should always be done with 4 spaces.
There is one part of the template which I don't understand, starting at line
149:
[% IF (ediaccount) %]
<div class="btn-group"><a href="[% script_name
%]?op=ediprint&basketgroupid=[% basketgroupid %]&booksellerid=[%
booksellerid %]" class="btn btn-default btn-sm" id="printbutton"><i class="fa
fa-download"></i> Generate EDIFACT order</a></div>
[% ELSE %]
<div class="btn-group"><a href="[% script_name
%]?op=ediprint&basketgroupid=[% basketgroupid %]&booksellerid=[%
booksellerid %]" class="btn btn-default btn-sm" id="printbutton"></div>
[% END %]
What is the purpose of the [% ELSE %] section? The <a> tag is incomplete, so I
would expect this to break HTML rendering somehow.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list