[Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #106 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Katrin Fischer from comment #89)
> 
> 2) Unit tests
> 
> c) Changes to Koha/MetaSearcher are untested.
> d) New svc/cataloguing/import_batches is untested.
> e) New svc/cataloguing/metasearch
As far as i know, we don't test scripts in svc (currently 0 test). I'm not
aware
of a valid method to do that.

About Koha/MetaSearcher. I started writing units tests but i encountered a
problem:
The method in charge of searching use forked process. That make the db context
set in UT lost.
The only way i found to make it works: commit all db changes. But this is quite
unsafe.
> 
> 5) Some first notes from GUI testing
> 
> a) I am not completely sold on the placement of the 'Save to' box. It
> already looks a bit 'squashed' and it will look worse in other languages
> (being German I know our words for things tend to be longer)
>
I also have long batch names. But i believe text is properly handle with line
returns.
And i think this box positioning/sizing is consistent with the search one.
Maybe you/someone can do a better proposal

I think all the rest is fixed or improved.
Put this back to needs signoff since there is some behavior changes

-- 
You are receiving this mail because:
You are watching all bug changes.