[Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store'

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Martin Renvoize from comment #10)
> (In reply to Jonathan Druart from comment #8)
> > Also, I think, my version will be faster: the fix is done only the
> > attributes we are updating, not all the attributes of the object.
> 
> Again, I would suggest this is a bug in our store routine as it stands..
> update really should just be shortcut to set + store else we're introducing
> bugs by having two distinct ways of doing the same thing.

Ok! :)

> Also, in my patch because you're calling the parent store method you're not
> only dealing with the over-rides withs Koha::Object but also any class
> specific overrides in, for example, Koha::Patron are you not?

I do not get what you mean.


I think we should investigate the warning and provide tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.