[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Séverine Queune from comment #3)
> Hi Jonathan,
> 
> I found 2 issues.
> 
> I have this software error : "Tag "" is not a valid tag. at
> /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a
> suggestion using the empty form (opac & staff client) and saving a
> suggestion modification on staff client (no problem using the checkbox and
> drop-down menu).

I do not understand that one. There are 2 bugs opened with this error but no
idea where the error comes from. Can you detail a bit more?
Reading the code it seems related to the item type.

(for the record)
685     my ($it_tag, $it_subfield) =
GetMarcFromKohaField('biblioitems.itemtype', '');
686     if ($record->field( $it_tag )) {
687         $record->field( $it_tag )->add_subfields( $it_subfield =>
$suggestion->{itemtype} );
688     }
689     else {
690         $record->append_fields(
691             MARC::Field->new($it_tag, ' ', ' ', $it_subfield =>
$suggestion->{itemtype})
692         );
693     }



> For suggestions made from an existing notice, suggestion status is not
> update after the adding to a basket (no problem for suggestions made from
> the empty form, and for the "Available" status after the receipt).

Fixed!

> Except these point, everything seems very clear to me and respond to our
> needs, so thanks a lot !
> Icon on opac is ok for me.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.