[Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963

--- Comment #6 from Séverine Queune <severine.queune at bulac.fr> ---
(In reply to Jonathan Druart from comment #5)
> (In reply to Séverine Queune from comment #3)
> > Hi Jonathan,
> > 
> > I found 2 issues.
> > 
> > I have this software error : "Tag "" is not a valid tag. at
> > /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a
> > suggestion using the empty form (opac & staff client) and saving a
> > suggestion modification on staff client (no problem using the checkbox and
> > drop-down menu).
> 
> I do not understand that one. There are 2 bugs opened with this error but no
> idea where the error comes from. Can you detail a bit more?
> Reading the code it seems related to the item type.
> 
> (for the record)
> 685     my ($it_tag, $it_subfield) =
> GetMarcFromKohaField('biblioitems.itemtype', '');
> 686     if ($record->field( $it_tag )) {
> 687         $record->field( $it_tag )->add_subfields( $it_subfield =>
> $suggestion->{itemtype} );
> 688     }
> 689     else {
> 690         $record->append_fields(
> 691             MARC::Field->new($it_tag, ' ', ' ', $it_subfield =>
> $suggestion->{itemtype})
> 692         );
> 693     }

Oh... Weird... In my instance, there is no field mapped to
biblioitems.itemtype, but if  I add one, I can save the suggestion correctly.
Is it the expected / future behaviour ?
This a problem we don't have with 18.05.00 so we'll have to be be aware about
adding a mapping for biblioitems.itemtype if so.

My second try was an on different computer with a different resolution screen,
I noticed a tiny display issu with the new link in OPAC (see attachement).
Sorry I missed that on first test.

-- 
You are receiving this mail because:
You are watching all bug changes.