[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #67 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #57)
> Some more QA comments:
> 
> 1. Enabled by default?
> At least it should not in the upgrade.

Solved.

> 2. Users can still access their holds history using the REST API even if the
> pref is off, is that expected?

I think it is, the syspref is about visibility.

> 5. return (data&&$date(data))||'';
> Should be removed (see one of the follow-ups on bug 24980).

What is the status of that bug and why is it still In discussion?

> 7. why do you need koha_objects_class for items and biblios in the schema?
> You should not.

This is fixed.

> 8. DBIC schema adds FK on old_reserves, that's wrong.

It adds relationships. There's nothing wrong about it, They are used in
Koha::Objects->to_api to embed related objects.

> 9. Even if Signed off already, please squash some patches when needed
> (rename of the script for instance).

Done

-- 
You are receiving this mail because:
You are watching all bug changes.