[Koha-bugs] [Bug 20936] Holds History for patrons in OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

--- Comment #68 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 103950
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103950
Bug 20936: Add patron's hold history menu in OPAC

Review of attachment 103950:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20936&attachment=103950)
-----------------------------------------------------------------

::: Koha/REST/V1/Patrons/Holds.pm
@@ +61,5 @@
> +        my $holds     = $c->objects->search( $holds_set );
> +        return $c->render( status => 200, openapi => $holds );
> +    }
> +    catch {
> +        $c->unhandlede_exception($_);

typo, should be unhandled_excecption

::: koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc
@@ +58,4 @@
>                  <a href="/cgi-bin/koha/opac-search-history.pl">your search history</a></li>
>              [% END %]
>  
> +            [% IF opacreadinghistory || Koha.Preference('OPACHoldsHistory') == 1 %]

You don't need this combined condition

@@ +77,2 @@
>                  [% END %]
> +                [% IF ( OPACPrivacy || Koha.Preference('OPACHoldsPrivacy') == 1 ) %]

the OPACHoldsPrivacy does not exist, this change should be reverted

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt
@@ +3,5 @@
> +[% USE KohaDates %]
> +[% INCLUDE 'doc-head-open.inc' %]
> +<title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog › Your holds history</title>
> +[% INCLUDE 'doc-head-close.inc' %]
> +[% BLOCK cssinclude %]

CSS should be in own file and added by Asset plugin

@@ +118,5 @@
> +[% INCLUDE 'datatables.inc' %]
> +[% INCLUDE 'js-date-format.inc' %]
> +<script>
> +    $(document).ready(function(){
> +        [% IF ( GoogleJackets ) %]KOHA.Google.GetCoverFromIsbn();[% END %]

Why Google Jackets and not other services?

::: opac/opac-holdshistory.pl
@@ +33,5 @@
> +use Koha::Patrons;
> +
> +use Koha::ItemTypes;
> +use Koha::Ratings;
> +

You don't need most of these imports

-- 
You are receiving this mail because:
You are watching all bug changes.