[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at helsinki.fi

--- Comment #129 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Jonathan Druart from comment #128)
> I thought a bit more about the priority=1 thing this morning.
> 
> And actually I have the feeling that the original issue described on this
> bug report could be fixed with the following (...one line!) change:
> 
> diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl
> index 01cf877b55..962ebe5609 100755
> --- a/circ/pendingreserves.pl
> +++ b/circ/pendingreserves.pl
> @@ -230,7 +230,7 @@ my $strsth =
>      AND items.itemnumber NOT IN (SELECT itemnumber FROM branchtransfers
> where datearrived IS NULL)
>      AND items.itemnumber NOT IN (SELECT itemnumber FROM reserves WHERE
> found IS NOT NULL AND itemnumber IS NOT NULL)
>      AND issues.itemnumber IS NULL
> -    AND reserves.priority <> 0 
> +    AND reserves.priority = 1
>      AND reserves.suspend = 0

This doesn't work because then rcount i.e. "Pull this many items" would only
show 1 when in reality you need to pull many more items also to fill those
other reserves.

PS. unrelated, but rcount is also incorrect, it should be the number of holds,
not amount of borrowers.

-- 
You are receiving this mail because:
You are watching all bug changes.