[Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #130 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Martin Renvoize from comment #127)
> This looks like a great improvement, movin us to searching via objects
> etc... but... dare I say it, can we move this to a module and thus add tests?

I think this definitely needs to use a module, the code population of
@all_items should be replaced with an object's method call that returns items
that can fill holds. Then it will make super easy to read code where you just
iterate over all the items and add the callnumber, shelving location, etc. info
to the $reserves variable that goes.

Btw, to resolve the original issue, can't we just order by reserve priority?
This refactoring could be in a separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.