[Koha-bugs] [Bug 25113] Make CirculationRules.t flexible for new scope combinations

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jul 7 12:45:42 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25113

--- Comment #4 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to Joonas Kylmälä from comment #3)
> In the patch you mention
> 
> > This also obsoletes the "Get effective issuing rule in correct order"
> > test in t/db_dependent/Koha/IssuingRules.t
> 
> why is it obsole(In reply to Joonas Kylmälä from comment #3)
> In the patch you mention
> 
> > This also obsoletes the "Get effective issuing rule in correct order"
> > test in t/db_dependent/Koha/IssuingRules.t
> 
> why is it obsoleted?

It is the test I refer to in the original post of this Bug.

> We used to test rule scopes by explicitly defining each combination.
> When adding new scopes, it is much easier if these tests are auto-
> generated for you so that you don't have to repeat similar code.
> Remove those "duplicates" ...

Manually adding 2^n tests, where n is the number of scopes, is no longer needed
because wiith this patch we are autogenerating those test cases.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list