[Koha-bugs] [Bug 25779] New: ExcludeHolidaysFromMaxPickUpDelay has opposite effect

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25779

            Bug ID: 25779
           Summary: ExcludeHolidaysFromMaxPickUpDelay has opposite effect
 Change sponsored?: ---
           Product: Koha
           Version: 19.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andreas.jonsson at kreablo.se
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Holds are set to expire during holidays, although the system has been
configured to not expire holds on holidays.


In C4/Hold.pm this code can be found:

    my $expirationdate = $today->clone;
    $expirationdate->add(days => $max_pickup_delay);

    if ( C4::Context->preference("ExcludeHolidaysFromMaxPickUpDelay") ) {
        $expirationdate = $calendar->days_forward( dt_from_string(),
$max_pickup_delay );
    }

However, if we look in the html-code for setting the system preference we can
see that the "true" value is labelled "Ignore the calendar".

    <select name="pref_ExcludeHolidaysFromMaxPickUpDelay"
id="pref_ExcludeHolidaysFromMaxPickUpDelay" class="preference preference-choice
valid">
      <option value="" selected="selected"> 
        Use the calendar
      </option>
      <option value="1">
        Ignore the calendar
      </option>
    </select>

So, I believe this condition should be reversed:

    my $expirationdate;

    if ( C4::Context->preference("ExcludeHolidaysFromMaxPickUpDelay") ) {
        $expirationdate->add(days => $max_pickup_delay);
    } else {
        $expirationdate = $today->clone;
        $expirationdate = $calendar->days_forward( dt_from_string(),
$max_pickup_delay );
    }

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.