[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
             Status|Signed Off                  |Failed QA

--- Comment #38 from Nick Clemens <nick at bywatersolutions.com> ---
This causes a behaviour change
 1 - This sets all patrons to want auto_renewal notices in digest form
 2 - The script requires '--digest' if the borrower wants digest or nothing is
sent
We should default to all patrons want auto_renewals but not digest
This could be combined too with bug 23787 where we add the 'AUTO_RENEWAL'
notice - if combined we could update borrowers to receive the notice if it
already exists, and insert it but do not set borrowers to receive the notice if
it does not exist

When running with the default notice the content is wrong, I think you want:
Dear [% borrower.firstname %] [% borrower.surname %],

        [% IF error %]
        There were [% error %] items that were not correctly renewed.
        [% END %]
        [% IF success %]
        There were [% success %] items that were correctly renewed.
        [% END %]


Additionally - the current code does not seem to allow for the inclusion of
item specific information in the notices, I would say this is a blocker.

Copyright line in auto-renewals is malformed in these patches

-- 
You are receiving this mail because:
You are watching all bug changes.