[Koha-bugs] [Bug 24368] Koha::Libraries->pickup_locations needs refactoring/ratifying

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24368

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=25421                   |
         Depends on|                            |25421

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
This needs to be removed as it's been replaced by a combination of:
- Koha::Biblio->pickup_locations
- Koha::Item->pickup_locations

The only remaining use was not passing parameters and thus all the logic in
there was not used at all [1]

This patches removes the method and tests, and also refactor the tests for the
(once using this) Koha::Template::Plugin::Branches::pickup_locations method to
cover the cases in more detail.

[1] See bug 25421


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25421
[Bug 25421] Inconsistent return value in Koha::Libraries->pickup_locations
-- 
You are receiving this mail because:
You are watching all bug changes.